Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shields Ad/Fingerprint block setting questions #12415

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Feb 25, 2022

Resolves brave/brave-browser#21345

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Start with fresh installation of browser
  2. Access brave://local-state. Verify that the P3A metrics Brave.Shields.AdBlockSetting and Brave.Shields.FingerprintBlockSetting have a value of 1.
  3. Change the global "Trackers & ads blocking" setting to "Aggressive". Verify that the ad block setting metric has a value of 2, on the local state page. Verify that the fingerprint block setting metric still has a value of 1.
  4. Change the global "Trackers & ads blocking" setting to "Standard". Verify that the ad block setting metric has a value of 1, on the local state page.
  5. Change the global "Trackers & ads blocking" setting to "Disabled". Verify that the ad block setting metric has a value of 0, on the local state page.
  6. Change the global "Fingerprinting blocking" setting to "Strict". Verify that the fingerprint block setting metric has a value of 2. Verify that the ad block setting metric still has a value of 0.
  7. Change the global "Fingerprinting blocking" setting to "Standard". Verify that the fingerprint block setting metric has a value of 1.
  8. Change the global "Fingerprinting blocking" setting to "Disabled". Verify that the fingerprint block setting metric has a value of 0.

@bbondy bbondy removed their request for review February 25, 2022 21:52
@@ -359,6 +363,10 @@ void SetFingerprintingControlType(HostContentSettingsMap* map,
ContentSettingsType::BRAVE_FINGERPRINTING_V2, content_setting);

RecordShieldsSettingChanged(local_state);
if (url.is_empty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why not put it into DefaultBraveShieldsHandler::SetFingerprintingControlType ?

Copy link
Collaborator Author

@DJAndries DJAndries Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that Android has it's own preference bridge/handler, so I thought I'd add it here so that the reporting works on all platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global fingerprint/ad-blocking configuration P3A questions
2 participants