Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Drip's email tracker from URLs #8975

Closed
fmarier opened this issue Apr 2, 2020 · 3 comments · Fixed by brave/brave-core#7968
Closed

Filter out Drip's email tracker from URLs #8975

fmarier opened this issue Apr 2, 2020 · 3 comments · Fixed by brave/brave-core#7968
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy/tracking Preventing sites from tracking users across the web privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include

Comments

@fmarier
Copy link
Member

fmarier commented Apr 2, 2020

Drip uses the __s query string parameter to link user visits to a website back to their email address.

Here's an abridged example:

$ curl -i https://t.dripemail2.com/c/eyJhY2NvdW50X2lkIjoiNTQzOTc1OSIs...WxwLTEwMS8_X19zPXpjcmFhdHNqYnRlc3NzbjJraXlrIn0
HTTP/2 307 
date: Thu, 02 Apr 2020 00:02:48 GMT
content-length: 0
location: https://skipperotto.com/kelp-101/?__s=zcra...2kiyk

The long parameter in the first URL is a base64 encoding of the following information:

{
    "account_id": "5439759",
    "delivery_id": "9ne...gdv",
    "url":"https://skipperotto.com/kelp-101/"
}

According to the Drip documentation, removing this parameter "disables Drip’s ability to identify new people and track already identified people."

@fmarier fmarier self-assigned this Apr 2, 2020
@fmarier fmarier added the privacy/tracking Preventing sites from tracking users across the web label Apr 2, 2020
@fmarier fmarier changed the title Filter out Drip's email tracker Filter out Drip's email tracker from URLs Apr 3, 2020
@fmarier
Copy link
Member Author

fmarier commented Jun 15, 2020

Since this is a pretty generic-looking parameter name, we might want to restrict the query filter further before adding this to the list:

@fmarier fmarier added the priority/P4 Planned work. We expect to get to it "soon". label Jun 23, 2020
@fmarier fmarier added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 19, 2021
@fmarier fmarier added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 16, 2021
@fmarier fmarier added this to the 1.22.x - Nightly milestone Feb 18, 2021
@stephendonner
Copy link

Verified FIXED using the testplan from brave/brave-core#7968 with

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)
  1. Open https://brave.com/?fbclid=1234 in a new tab.
  2. Check that the fbclid query parameter is missing from the URL bar.
    drip-shields-on
  3. Turn Shields OFF for brave.com.
  4. Open https://brave.com/?fbclid=5678 in a new tab.
  5. Check that the fbclid query parameter is present in the URL bar.
    drip-shields-off
  6. Turn Shields ON for brave.com.
  7. Open https://brave.com/?__s=abcd in a new tab.
  8. Check that the __s query parameter is missing from the URL bar.
    drip-abcd-shields-on

@srirambv
Copy link
Contributor

srirambv commented Mar 9, 2021

Verification passed on OnePlus 6T with Android 10 running 1.22.54 x64 beta build

Android.ARM.mp4

Verification passed on Samsung Tab A with Android 10 running 1.22.54 x64 beta build

Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy/tracking Preventing sites from tracking users across the web privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants