Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neowin.net webview crashes on first launch. #761

Closed
GeetaSarvadnya opened this issue Aug 17, 2018 · 7 comments · Fixed by brave/brave-core#378
Closed

Neowin.net webview crashes on first launch. #761

GeetaSarvadnya opened this issue Aug 17, 2018 · 7 comments · Fixed by brave/brave-core#378
Labels
crash/webview Only tab webview crash. Browser doesn't crash feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 17, 2018 •
edited
Loading

Description

Neowin.net webview is getting crashed on first launch. When page gets refreshed it works as expected,

Steps to Reproduce

  1. Launch Brave with clean profile from CLI
  2. Open Neowin.net website

Actual result:

Neowin.net webview crashes on first launch
neowin webview crash

image

Console Error:
image

Expected result:

Webview should not crash

Reproduces how often:

100% Reproducible rate

Brave version (about:brave info)

Version 0.54.0 Chromium: 69.0.3497.32 (Official Build) dev (64-bit)

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? - No
  • Is the issue reproducible on the latest version of Chrome? - No

Additional Information

cc: @bbondy
@GeetaSarvadnya GeetaSarvadnya added the crash/webview Only tab webview crash. Browser doesn't crash label Aug 17, 2018
@GeetaSarvadnya GeetaSarvadnya added this to the Backlog milestone Aug 17, 2018
@GeetaSarvadnya GeetaSarvadnya added the feature/shields/adblock Blocking ads & trackers with Shields label Aug 17, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Neowin.net webview crashes on first launch Neowin.net webview crashes on first launch due to Ad blocker Aug 17, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Neowin.net webview crashes on first launch due to Ad blocker Neowin.net webview crashes on first launch. Aug 17, 2018
@bbondy
Copy link
Member

bbondy commented Aug 17, 2018

I don't reproduce.

@bbondy
Copy link
Member

bbondy commented Aug 17, 2018

on macOS, both the last developer channel build and on my local dbug build.

@bbondy
Copy link
Member

bbondy commented Aug 17, 2018

@GeetaSarvadnya could you press on Send now on the crash and then copy and paste the crash report here? Thank you!

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 17, 2018 •
edited
Loading

@bbondy Please find the crash report below:

Uploaded Crash Report ID d1f9f7e151b524ef (Local Crash ID: d012165c-25a3-4cc8-b5b5-2b8cd79d3cee)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:44 PM

Provide additional details

Uploaded Crash Report ID ecb8ee5695f2a4d6 (Local Crash ID: ae155131-bd45-43b0-8177-7d70fb60709a)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:46 PM

Provide additional details

Uploaded Crash Report ID cfff44734cdc8ec9 (Local Crash ID: 6546ad79-9c78-4db3-8de6-e783196c990f)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:47 PM

Provide additional details

Uploaded Crash Report ID 813c3ef27d203b9e (Local Crash ID: 84c3a05c-6211-4bf3-8bb3-79b00c94d51b)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:48 PM

Provide additional details

Uploaded Crash Report ID bbee9d12c4a59e6e (Local Crash ID: 07d09aad-4534-4268-8e79-50a79618403b)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:48 PM

Provide additional details

Uploaded Crash Report ID be76c87525936c0f (Local Crash ID: 0318cf8b-acfd-486e-851c-a0a972108b87)
Crash report captured on Friday, August 17, 2018 at 8:57:51 PM, uploaded on Friday, August 17, 2018 at 9:05:49 PM

Provide additional details

@GeetaSarvadnya GeetaSarvadnya modified the milestones: Backlog, Releasable builds 0.55.x Aug 17, 2018
@GeetaSarvadnya
Copy link
Author

Tested the above issue on latest build 0.54.1. Issue still persists,please find the crash id below:
Crash Report ID b81e7e125679caa0
cc: @bbondy

@GeetaSarvadnya
Copy link
Author

@bbondy : Crash Report ID ae29bfa656f299d6

@bbondy bbondy added the QA/Yes label Aug 31, 2018
@bbondy bbondy mentioned this issue Aug 31, 2018
Merged
11 tasks
bbondy added a commit to brave/brave-core that referenced this issue Aug 31, 2018
@bbondy
Use a single sequenced task runner for HTTPSEverywehre
0532a57 
Otherwise we're creating lots of different threads and accessing things for the DB on different possibly overlapping threads

I think this also fixes:
brave/brave-browser#707
brave/brave-browser#708
brave/brave-browser#739
brave/brave-browser#797
brave/brave-browser#761
brave/brave-browser#762
brave/brave-browser#796
brave/brave-browser#797
brave/brave-browser#798
brave/brave-browser#861
@btlechowski
Copy link

btlechowski commented Sep 20, 2018 •
edited by srirambv
Loading

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Pass with
Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash/webview Only tab webview crash. Browser doesn't crash feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use a single sequenced task runner for HTTPSEverywehre && level_db init fix brave/brave-core
5 participants
@bbondy @srirambv @LaurenWags @btlechowski @GeetaSarvadnya