Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable new extension APIs for non-brave extensions #602

Closed
jumde opened this issue Jul 19, 2018 · 2 comments
Closed

Disable new extension APIs for non-brave extensions #602

jumde opened this issue Jul 19, 2018 · 2 comments

Comments

@jumde
Copy link
Contributor

jumde commented Jul 19, 2018

New APIs defined here should be available for only brave blessed_extensions - common/extensions/api/brave_shields.json

@bbondy
Copy link
Member

bbondy commented Aug 18, 2018

QA steps:
Go to the background page of any extension, check in the console if this is defined: chrome.braveShields it should be undefined but chrome should be defined.

@srirambv
Copy link
Contributor

srirambv commented Sep 25, 2018

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

image

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

image

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

screen shot 2018-10-01 at 2 02 27 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants