Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #28652] Strings are not translated for "Open external links in Brave" #30947

Closed
hffvld opened this issue Jun 9, 2023 · 2 comments · Fixed by brave/brave-core#19078
Assignees

Comments

@hffvld
Copy link
Contributor

hffvld commented Jun 9, 2023

Description

Follow-up to #28652

Steps to reproduce

  1. Switch device language from English to any other one
  2. Launch Brave
  3. Three-dot Menu > Settings
  4. Scroll down and find Open external links in Brave > Observe

Actual result

Open external links in Brave and Opens link from other apps in a Brave webview. Note: Brave must be set as your default browser. are not translated to other languages.

Spanish German Russian Japanise
1 2 3 4

Expected result

Open external links in Brave and Opens link from other apps in a Brave webview. Note: Brave must be set as your default browser. must be translated to other languages.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 7 (phone)
  • Android version: Android 14 [panther_beta-user 14 UPB3.230519.008 release-keys]

Brave version

Brave build: 1.53.83
Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.53.107 or higher for 1.53.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 12, 2023
@hffvld
Copy link
Contributor Author

hffvld commented Jul 12, 2023

Verified on Pixel 7 using version(s):

Device/OS: 
- Pixel 7 [panther_beta-user 14 UPB4.230623.005 release-keys]
Brave build: 1.56.3
Chromium: 115.0.5790.75 (Official Build) (64-bit)
Revision: 3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}

STEPS:

  1. Switch the device language from English to any other one
  2. Launch Brave
  3. Three-dot Menu > Settings
  4. Scroll down and find Open external links in Brave > Verify

ACTUAL RESULTS:

  • Verified Open external links in Brave and Opens link from other apps in a Brave webview. Note: Brave must be set as your default browser. are translated to other languages.

German Japanise Spanish French
1 2 3 4
Hebrew Russian Ukrainian Polish
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants