Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update "Open tabs in Custom Tabs" setting copy #28652

Closed
timchilds opened this issue Feb 21, 2023 · 1 comment · Fixed by brave/brave-core#18316
Closed

[Android] Update "Open tabs in Custom Tabs" setting copy #28652

timchilds opened this issue Feb 21, 2023 · 1 comment · Fixed by brave/brave-core#18316

Comments

@timchilds
Copy link

timchilds commented Feb 21, 2023

Description

Update the copy for the Open tabs in Custom Tabs settings toggle:

Header: Open external links in Brave webview
Description: Opens links from other apps in a Brave webview. Note: Brave must be set as your default browser.

Why

The existing copy does not accurately describe what happens when the setting is enabled.

cc @bradleyrichter @anthonypkeane @SergeyZhukovsky @samartnik @rmcfadden3

@hffvld
Copy link
Contributor

hffvld commented Jun 9, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB2.230407.019 release-keys]
Brave build: 1.53.83
Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}

NOTE: Confirmed with @deeppandya that the title string updated from Open external links in Brave webview to Open external links in Brave.

Filed follow-up issue #30947


STEPS:

  1. Launch Brave
  2. Three-dot Menu > Settings
  3. Scroll down and find Open external links in Brave > Verify

ACTUAL RESULTS:

  • Verified that the title is Open external links in Brave
  • Verified that subtitle is Opens link from other apps in a Brave webview. Note: Brave must be set as your default browser.
  • Verified that the default setting is ON
  • Verified that links are opened as expected depending on the setting ON or OFF

Screen_12-33-47

timestamp_12-49-48_12-51-00.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants