Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent should adapt to dark/light mode settings #24498

Closed
stephendonner opened this issue Aug 7, 2022 · 4 comments · Fixed by brave/brave-core#14584
Closed

WebTorrent should adapt to dark/light mode settings #24498

stephendonner opened this issue Aug 7, 2022 · 4 comments · Fixed by brave/brave-core#14584

Comments

@stephendonner
Copy link

Description

WebTorrent should adapt to dark/light mode settings

Steps to Reproduce

  1. install 1.44.26
  2. launch Brave
  3. set Brave colors to Dark
  4. load https://webtorrent.io/free-torrents
  5. click on any torrent or magnet link

Actual result:

Screenshot 2022-08-07 at 1 44 21 PM

Expected result:

The WebTorrent content should be Brave-colors aware, and adapt to Dark or Light modes

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.26 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 13.0 (Build 22A5311f)

cc @fallaciousreasoning @aguscruiz

@stephendonner stephendonner added bug feature/user-interface All UI related feature/webtorrent Label for webtorrent related issues OS/Desktop labels Aug 7, 2022
@fallaciousreasoning
Copy link

I'm happy to work on this if we can get a UX mock together 😄

@aguscruiz
Copy link

Added a mockup here @stephendonner @fallaciousreasoning
https://www.figma.com/file/wWRDxRJFw04gLPahfAjUrO/Desktop-WebTorrent?node-id=103%3A17994

There are some minor updates too, nothing in terms of actual user experience, but visual updates to make the design be in line with the Design system.

image

image

@fallaciousreasoning
Copy link

fallaciousreasoning commented Aug 8, 2022

Woohoo! New design looks great. All right, I'll try and jump on this later this week 😄

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.44.70 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified using original STR #24498 (comment)

Confirmed WebTorrent pages adapted to dark/light mode settings and pages matched to new Figma designs.

Dark

Before Download Downloading
image image

Light

Before download Downloading
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants