Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages persist when clicked on I have a Sync Code button in the Sync Setup page #23772

Closed
MadhaviSeelam opened this issue Jun 29, 2022 · 1 comment · Fixed by brave/brave-core#14308

Comments

@MadhaviSeelam
Copy link

Description

Error messages persist after closing the sync modal when incorrect sync chain codes are words entered in the brave://sync page. Refreshing the page clears error messages.

Steps to Reproduce

  1. Install 1.41.82
  2. Go to brave://sync
  3. Click Start using sync
  4. Click I have a Sync Code
  5. Enter incorrect sync chain code words (25)

    (elder core tesT tortoise exchange rare rapid crime kingdom street odor news either body general lock perfect catalog crane
    special act pet october soon paper )

  6. Click Confirm and OK in the next warning modal
  7. Correct error message returned - 'This code is invalid`
  8. Close (X) the modal
  9. Click on I have a Sync code button

Actual result:

Error message This code is invalid persists. Refreshed the page to clear error messages.

Step 5 Step 5A Step7 Actual Result Refresh page
image image <image image image

Expected result:

Error pages should be cleared upon closing the modal.

Reproduces how often:

Easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @AlexeyBarabash @rebron
@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified using original STR from the description #23772 (comment)

  1. Install 1.44.73
  2. Go to brave://sync
  3. Click Start using sync
  4. Click I have a Sync Code
  5. Enter incorrect sync chain code words
  6. Click Confirm and OK in the next warning modal
  7. Correct error message returned - 'This code is invalid`
  8. Close (X) the modal
  9. Click on I have a Sync code button

Confirmed This code is invalid error message no longer displayed. Blank sync code input text area displayed.

step5 step6 step7 result
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants