Add isBraveWallet property to window.ethereum

[josheleonard]

Description

A standard being used by web3 apps is to check that an injected wallet is present using window.ethereum[is<WalletName>]
eg. window.ethereum.isMetaMask

We already set window.ethereum.isMetaMask to true for compatibility with MetaMask

We should also set window.ethereum.isBraveWallet to true, so that web apps can detect that Brave Wallet is available for connecting

Actual result:

window.ethereum.isMetaMask is true
window.ethereum.isBraveWallet is undefined

Expected result:

window.ethereum.isMetaMask is true
window.ethereum.isBraveWallet is true

Miscellaneous Information:

Example of a library checking for injected providers: https://github.com/Web3Modal/web3modal/blob/master/src/providers/injected/index.ts

[kjozwiak]

Above requires 1.38.82 or newer for 1.38.x verification.

[srirambv]

Brave	1.38.106 Chromium: 101.0.4951.41 (Official Build)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	☑️ Linux	☑️ Windows 11 Version 22H2 (Build 22598.200)	☑️ macOS Version 12.0.1 (Build 21C52)
	Verified steps from brave/brave-core#12794
	21949-Linux.mp4	21949-Windows.mov	21949-macOS.mov

[PvanHengel]

Hi - we are trying to use this from iOS Mobile, and it does not seem to be set I see @srirambv and @avinassh posted about this, but I have the latest version and it does not seem to be working? Any update on iOS / Android? Is there another way to detect we are using the brave wallet?

[josheleonard]

Hi - we are trying to use this from iOS Mobile, and it does not seem to be set I see @srirambv and @avinassh posted about this, but I have the latest version and it does not seem to be working? Any update on iOS / Android? Is there another way to detect we are using the brave wallet?

You can try this method for detecting Brave. I verified that isBraveWallet detection is working on Android.

[StephenHeaps]

Hi - we are trying to use this from iOS Mobile, and it does not seem to be set I see @srirambv and @avinassh posted about this, but I have the latest version and it does not seem to be working? Any update on iOS / Android? Is there another way to detect we are using the brave wallet?

Hey @PvanHengel, thanks for the report. We've opened an issue on the iOS repo to track this.
brave/brave-ios#6059

[devstein]

Hi -- I updated my browser yesterday and now window.ethereum.isBraveWallet is no longer working. It's breaking connect modals like Picket. Here is the error

window.ethereum.isBraveWallet
VM98:14 Uncaught TypeError: Illegal invocation: Function must be called on an object of type JSEthereumProvider
    at Reflect.get (<anonymous>)
    at Object.get (<anonym

Edit: I meant window.ethereum.isBraveWallet not window.ethereum.isBraveWallet()

[josheleonard]

Hi -- I updated my browser yesterday and now window.ethereum.isBraveWallet is no longer working. It's breaking connect modals like Picket. Here is the error

window.ethereum.isBraveWallet()
VM98:14 Uncaught TypeError: Illegal invocation: Function must be called on an object of type JSEthereumProvider
    at Reflect.get (<anonymous>)
    at Object.get (<anonym

Hi @devstein,
window.ethereum.isBraveWallet is not a function and is only available when Brave Wallet is the selected "Default Ethereum wallet" option on the brave://settings/web3 settings page.

What version of Brave are you using?
I verified that brave wallet was detected on picketapi.com with version v1.49.120(MacOS)
I was not able to reproduce the error message on picketapi.com

[devstein]

Hi @josheleonard thank you! Setting brave as the default wallet in brave://settings/web3 fixed it for me. When did this behavior change? window.ethereum.isBraveWallet used to be undefined rather than throw an error. I've been using Brave and window.ethereum.isBraveWallet for almost a year without issue.

For Brave version, I'm also on v1.49.120 (MacOS)

For context, this new behavior also breaks RainbowKit

[josheleonard]

@devstein , this may have been caused by this PR: brave/brave-core#15498
@yrliou is looking into this now

[yrliou]

@devstein I can't seem to reproduce on v1.49.120 for that error, what Default Ethereum wallet setting did you have as the brave://settings/web3 before?
I tested with it set as extension and have metamask installed, can connect without issue and running window.ethereum.isBraveWallet in the console returns undefined for me.