Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vpn button toggle option in settings #17802

Closed
Tracked by #15804
simonhong opened this issue Sep 1, 2021 · 1 comment · Fixed by brave/brave-core#9998
Closed
Tracked by #15804

Add vpn button toggle option in settings #17802

simonhong opened this issue Sep 1, 2021 · 1 comment · Fixed by brave/brave-core#9998
Assignees
@simonhong
Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Milestone
1.31.x - Release

Comments

@simonhong
Copy link
Member

image
@simonhong
Copy link
Member Author

We launch vpn panel from vpn button but that button could be hidden.
Panel launching code should be separated from button.

@simonhong simonhong mentioned this issue Sep 6, 2021
Closed
38 tasks
@simonhong simonhong self-assigned this Sep 8, 2021
@simonhong simonhong mentioned this issue Sep 8, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 8, 2021
@simonhong
Added show vpn button toggle option
cfc2357 
fix brave/brave-browser#17802

VPN panel will be anchored to app menu button when vpn button is hidden.
@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Added show vpn button toggle option brave/brave-core
1 participant
@simonhong