macOS accessibility crash

[LaurenWags]

Description

Follow up to brave/brave-core#7708 (comment) and #13778 (comment)

While testing the above issue on 1.21.35, I was still able to get an accessibility crash. I was using the same steps as listed in #13778 (comment) however it took longer to reproduce the crash than when executing those steps with 1.21.30.

Crash report id: a81a0000-9cc8-c705-0000-000000000000

Steps to Reproduce

Pre-req: Have Typing Feedback enabled, I also enabled all 4 options on Catalina

1. Clean profile
2. Login to mail.google.com
3. Quickly open a new tab using cmd + t and type m immediately followed by pressing return.
4. Repeat step 3 quickly multiple times.
5. Brave crashed.

Note - original issue also lists closing the multiple tabs with cmd + w. This did not cause a crash for me, however it should be checked when this is fixed as well.

Actual result:

Brave crashes

Expected result:

No crash

Reproduces how often:

unsure, but crash seems to occur less frequently than version without the fix

Brave version (brave://version info)

Brave | 1.21.35 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @iefremov @kjozwiak

[LaurenWags]

Verified passed with macOS x64 10.15.7 (Catalina)

Brave | 1.20.104 Chromium: 88.0.4324.152 (Official Build) (x86_64)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | macOS Version 10.15.7 (Build 19H512)

Verified using STR from #13837 (comment). No crash was observed.
Also per note in the issue, closed tabs using cmd + w rapidly. Again, no crash was observed.

---

Verified passed with macOS x64 10.14.6 (Mojave)

Brave	1.20.104 Chromium: 88.0.4324.152 (Official Build) (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 10.14.6 (Build 18G103)

Verified using STR from #13837 (comment). No crash was observed. Note - Mojave does not have the required settings to test the exact STR. An approximation of settings was used instead.

---

As much as can be, verified passed with macOS x64 11.2.1 (Big Sur) using STR from #13837 (comment). No crash was observed with the limited, approximated accessibility-keyboard settings.

Brave	1.20.104 Chromium: 88.0.4324.152 (Official Build) (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2.1 (Build 20D74)