Fix Totp tests #3527
Merged
Fix Totp tests #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the errors we see coming from yarn audit are for dev dependencies which have no impact in production. See: rails/webpacker#2969 (comment) and rails/webpacker#3017 (comment) We need to be able to suppress warnings which do not apply.
thypon
reviewed
Jan 20, 2022
Gemfile
Outdated
| def x86_64? | ||
| `uname -p`.strip == "x86_64" | ||
| def not_m1? | ||
| `uname -p`.strip != "arm64" |
There was a problem hiding this comment.
On M1 uname -p is returning "arm" and not "arm64". I was using x86_64 since even Linux arm is broken.
There was a problem hiding this comment.
I got arm64 on my m1, weird. I can update to include both arm and arm64
thypon
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the failing TOTP Tests.