Make api keys optional when running tests. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @matthusby! I see where you're coming from with this. At the same time, having it error loudly has helped me when I moved development to another machine and the ENV wasn't all the way setup yet. I'll think a bit more about this. |
|
Yeah I can see that being useful. I was coming at this from the default should just work, but if you are testing those api's then this does in fact break the just work part. How do you feel about logging a notice if the key could not be found? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the test without having all the API keys set this would blow up even if you are not testing that api. This will just try to load them and continue.