-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taxonomy): added metadata taxonomy field support #3710
feat(taxonomy): added metadata taxonomy field support #3710
Conversation
b007a11
to
fc302d3
Compare
bceaf14
to
5a4998a
Compare
…data-taxonomy-options-api # Conflicts: # package.json # src/elements/content-sidebar/MetadataInstanceEditor.tsx # src/elements/content-sidebar/MetadataSidebarRedesign.tsx # src/elements/content-sidebar/__tests__/MetadataInstanceEditor.test.tsx # yarn.lock
const params = { | ||
...(marker ? { marker } : {}), | ||
...(searchInput ? { searchInput } : {}), | ||
...(query_text ? { query_text } : {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit but should this be camel cased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional as the query string param is required in snake case (ie /metadata?query_text=search
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -169,6 +171,14 @@ function MetadataSidebarRedesign({ api, elementId, fileId, onError, isFeatureEna | |||
const showList = !showEditor && templateInstances.length > 0 && !editingTemplate; | |||
const areAiSuggestionsAvailable = isExtensionSupportedForMetadataSuggestions(file?.extension ?? ''); | |||
|
|||
const taxonomyOptionsFetcher = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i don't think the async
is needed since we're not directly using await
. the function will still be a promise since metadataTaxonomyFetcher
is async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this repo favors utils
folder path
eld (if returned by the backend)