feat(api): add handling empty metadata suggestions #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JakubKida
force-pushed
the
empty-metadata-suggestions-error
branch
from
e45293b
to
25149cc
Compare
greg-in-a-box
approved these changes
Aug 12, 2024
greg-in-a-box
requested changes
Aug 12, 2024
wpiesiak
reviewed
Aug 13, 2024
| .fn() | ||
| .mockResolvedValueOnce('global') | ||
| .mockResolvedValueOnce('enterprise'); | ||
| metadata.getTemplates = jest.fn().mockResolvedValueOnce('global').mockResolvedValueOnce('enterprise'); |
There was a problem hiding this comment.
Are those formatting changes necessary?
There was a problem hiding this comment.
Prettier changed them by default, not sure if I have it set up wrong or were the latest guidelines not applied to this file
wpiesiak
approved these changes
Aug 13, 2024
JakubKida
force-pushed
the
empty-metadata-suggestions-error
branch
from
38e20b7
to
f039507
Compare
greg-in-a-box
approved these changes
Aug 13, 2024
greg-in-a-box
changed the title
JChan106
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an
ERROR_CODE_EMPTY_METADATA_SUGGESTIONSerror on receiving no AI suggestions for metadata.