Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata-sidebar): add metadata empty state to metadata sidebar redesign #3605

Conversation

karolinaru
Copy link
Contributor

Screenshot 2024-08-07 at 10 31 16 Screenshot 2024-08-07 at 10 32 45

@karolinaru karolinaru requested review from a team as code owners August 8, 2024 14:28
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2024

CLA assistant check
All committers have signed the CLA.

@wpiesiak wpiesiak force-pushed the metadata-sidebar-redesign branch 2 times, most recently from 4bf0c9e to 897a5c7 Compare August 19, 2024 16:17
@karolinaru karolinaru force-pushed the ADOPT-4315-Add-MetadataEmptyState-to-MetadataSidebarRedesign branch from 6002a63 to b08bc35 Compare August 21, 2024 11:56
.gitignore Outdated Show resolved Hide resolved
jankowiakdawid and others added 2 commits August 26, 2024 12:47
while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface
@karolinaru karolinaru force-pushed the ADOPT-4315-Add-MetadataEmptyState-to-MetadataSidebarRedesign branch from 4710b3f to 8a27b2c Compare August 26, 2024 13:05
@karolinaru karolinaru merged commit ecff691 into box:metadata-sidebar-redesign Aug 26, 2024
3 of 4 checks passed
jankowiakdawid added a commit that referenced this pull request Aug 29, 2024
…redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit that referenced this pull request Sep 6, 2024
…redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit that referenced this pull request Sep 11, 2024
…redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit that referenced this pull request Sep 13, 2024
…redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 16, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 17, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit that referenced this pull request Sep 17, 2024
…redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
mergify bot added a commit that referenced this pull request Sep 17, 2024
* feat(metadata-sidebar): Add metadata add template dropdown menu (#3606)

* feat(metadata-sidebar): Add AddMetadataTemplateDropdown

and improve basic styling

* feat(metadata-sidebar): Fix failing tests

Extend Jest configuration to not transforming metadata-editor code

* feat(metadata-sidebar): add AddMetadataTemplateDropdown

To MetadataSidebarRedesign

* feat(content-sidebar): Bring back changes to mockServiceWorker.js

No idea why they got there in the first place

* feat(metadata-sidebar): update storybook

* feat(metadata-sidebar): PR comments

* feat(metadata-sidebar): simplify storybook

* feat(metadata-sidebar): enum status

* feat(metadata-sidebar): global variables and enum upper case change

* feat(metadata-sidebar): useSidebarMetadataFetcher tests

* feat(metadata-sidebar): useSidebarMetadataFetcher tests

* feat(metadata-sidebar): PR comments

* feat(metadata-sidebar): PR comments

* feat(metadata-sidebar): loading status test

* feat(metadata-sidebar): use SidebarContent + tests

* feat(metadata-sidebar): template dropdown menu nit fixes

---------

Co-authored-by: Karolina Rusek-Bieniek <krusek@box.com>
Co-authored-by: Wiola <wpiesiak@box.com>

* feat(metadata-sidebar): add metadata empty state to metadata sidebar redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>

* feat(metadata-sidebar): Metadata Instance Editor (#3632)

* feat(metadata-sidebar): metadata instance editor

* feat(metadata-sidebar): modal and tests

* feat(metadata-sidebar): isLoading change

* feat(metadata-sidebar): change imports

* feat(metadata-sidebar): pr comments

* feat(metadata-sidebar): Metadata.test.js test fix

* feat(metadata-sidebar): modal story additional check

* feat(metadata-sidebar): modal open prop

* feat(metadata-sidebar): stories

* feat(metadata-sidebar): lint comments

* feat(metadata-sidebar): stories update

* feat(metadata-sidebar): Disable lint for 2 console.logs

---------

Co-authored-by: Karolina Rusek-Bieniek <krusek@box.com>
Co-authored-by: Wiola <wpiesiak@box.com>
Co-authored-by: karolinaru <91914885+karolinaru@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
karolinaru added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 18, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 18, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
jankowiakdawid added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 18, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
* feat(metadata-sidebar): add metadata empty state to metadata sidebar redesign (#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>

* feat(metadata-sidebar): Display MetadataInstanceList

* feat(metadata-sidebar): Add stories for AddTemplateDropdownMenu

Plus fix syncing when some metadata template instances are already loaded

* feat(metadata-sidebar): Move TooltipProvider to ContentSidebar

* feat(metadata-sidebar): Add unit test for showing MetadataInstanceList

* feat(metadata-sidebar): Update stories

* feat(metadata-sidebar): Reorganize stories

* feat(metadata-sidebar): Handle edition cancelation

* feat(metadata-sidebar): bump metadata-editor version

* feat(metadata-sidebar): Don't show list when metadata is being edited

* feat(metadata-sidebar): Bump @box/metadata-editor version

* feat(metadata-sidebar): Fix tests

* feat(metadata-sidebar): Update story name

* feat(metadata-sidebar): Remove data-testid attribute

And timeout

* feat(metadata-sidebar): Use `getByRole` for test expect

Co-authored-by: greg-in-a-box <103291617+greg-in-a-box@users.noreply.github.com>

* feat(metadata-editor): Reorganize showing editor views

+ move AutofillContextProvider where it's needed

---------

Co-authored-by: karolinaru <91914885+karolinaru@users.noreply.github.com>
Co-authored-by: greg-in-a-box <103291617+greg-in-a-box@users.noreply.github.com>
karolinaru added a commit to jankowiakdawid/box-ui-elements that referenced this pull request Sep 19, 2024
…redesign (box#3605)

* chore(content-sidebar): Temporarily remove files

while we be working with not yet publish internal library.
Will remove this commit after the library will become publicly
available on NPM and added to BUIE.

feat(metadata-sidebar): MetadataEmptyState

feat(metadata-sidebar): comment api to pass test

feat(metadata-sidebar): uncomment comments

feat(metadata-sidebar): add states

feat(metadata-sidebar): tests update

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): delete git add . in showEditor

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): storybook tests

feat(metadata-sidebar): update unit tests

feat(metadata-sidebar): pr comments

feat(metadata-sidebar): variables name changes

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): global token change  and status enum

feat(metadata-sidebar): global token update

feat(metadata-sidebar): global variables and enum upper case change

feat(metadata-sidebar): PR comments

feat(metadata-sidebar): styles import and title deletion

feat(metadata-sidebar): convert type to interface

* feat(metadata-sidebar): missing tests after rebase

---------

Co-authored-by: Dawid Jankowiak <jankowiak.dawid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants