feat(blueprint): Added blueprint #3585
Conversation
greg-in-a-box
force-pushed
the
blueprint-web
branch
3 times, most recently
from
4465671
to
e08963f
Compare
greg-in-a-box
force-pushed
the
blueprint-web
branch
from
e08963f
to
f52ba86
Compare
| @@ -73,6 +73,7 @@ function getConfig(isReactExternalized) { | |||
| examples: path.join(__dirname, '../examples/src'), // for examples only | |||
| 'box-ui-elements-locale-data': path.resolve(`i18n/${language}`), | |||
| 'box-locale-data': path.resolve(`node_modules/@box/cldr-data/locale-data/${language}`), | |||
| lodash : path.resolve('node_modules/lodash'), | |||
There was a problem hiding this comment.
had to put this in because it was looking for lodash/merge within blueprint when it wasnt there
There was a problem hiding this comment.
I'm not clear on why this is needed since lodash is already present in package.json. Do we have a type mismatch? Or a misconfigured dependency in Blueprint?
| .bcu-footer-message { | ||
| padding: 0 10px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .bcu-footer-right .btn { | ||
| margin-left: 8px; |
There was a problem hiding this comment.
doesnt look good if i left this in with the new buttons
greg-in-a-box
force-pushed
the
blueprint-web
branch
from
f52ba86
to
e6db64f
Compare
greg-in-a-box
force-pushed
the
blueprint-web
branch
from
e6db64f
to
c71a037
Compare
package.json
Outdated
| @@ -316,6 +318,8 @@ | |||
| "yargs": "^15.1.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@box/blueprint-web": "^7.2.4", | |||
There was a problem hiding this comment.
is there any reason why we have different version in peerDependecies?
There was a problem hiding this comment.
greg-in-a-box
force-pushed
the
blueprint-web
branch
from
c71a037
to
40d8fe4
Compare
greg-in-a-box
force-pushed
the
blueprint-web
branch
from
40d8fe4
to
9c00f38
Compare
| @@ -73,6 +73,7 @@ function getConfig(isReactExternalized) { | |||
| examples: path.join(__dirname, '../examples/src'), // for examples only | |||
| 'box-ui-elements-locale-data': path.resolve(`i18n/${language}`), | |||
| 'box-locale-data': path.resolve(`node_modules/@box/cldr-data/locale-data/${language}`), | |||
| lodash : path.resolve('node_modules/lodash'), | |||
There was a problem hiding this comment.
I'm not clear on why this is needed since lodash is already present in package.json. Do we have a type mismatch? Or a misconfigured dependency in Blueprint?
| @@ -3021,6 +3291,22 @@ | |||
| "@radix-ui/react-use-size" "1.0.1" | |||
| "@radix-ui/rect" "1.0.1" | |||
|
|
|||
| "@radix-ui/react-popper@1.2.0": | |||
There was a problem hiding this comment.
It's not ideal to have two versions of the same library. It looks like we're already importing several @radix-ui libraries via Storybook. Should we look at upgrading to get the versions in sync?
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Added Blueprint