feat(content-sidebar): Add placehoder metadatasidebar redesigned #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
3 times, most recently
from
3d52c5e
to
05df107
Compare
jankowiakdawid
changed the title
jstoffan
reviewed
Jul 5, 2024
We don't have yet. I was hoping we can get this one to |
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
from
05df107
to
f611ea3
Compare
JChan106
reviewed
Jul 15, 2024
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
2 times, most recently
from
0772506
to
489d4dc
Compare
JChan106
previously approved these changes
Jul 16, 2024
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
from
489d4dc
to
ba48d9b
Compare
tjuanitas
reviewed
Jul 17, 2024
| @@ -74,6 +79,7 @@ const MARK_NAME_JS_LOADING_DETAILS = `${ORIGIN_DETAILS_SIDEBAR}${BASE_EVENT_NAME | |||
| const MARK_NAME_JS_LOADING_ACTIVITY = `${ORIGIN_ACTIVITY_SIDEBAR}${BASE_EVENT_NAME}`; | |||
| const MARK_NAME_JS_LOADING_SKILLS = `${ORIGIN_SKILLS_SIDEBAR}${BASE_EVENT_NAME}`; | |||
| const MARK_NAME_JS_LOADING_METADATA = `${ORIGIN_METADATA_SIDEBAR}${BASE_EVENT_NAME}`; | |||
| const MARK_NAME_JS_LOADING_METADATA_REDESIGNED = `${ORIGIN_METADATA_SIDEBAR_REDESIGN}${BASE_EVENT_NAME}`; | |||
There was a problem hiding this comment.
ORIGIN_METADATA_SIDEBAR_REDESIGN no longer exists - was previously the same as ORIGIN_METADATA_SIDEBAR
Suggested change
| const MARK_NAME_JS_LOADING_METADATA_REDESIGNED = `${ORIGIN_METADATA_SIDEBAR_REDESIGN}${BASE_EVENT_NAME}`; | |
| const MARK_NAME_JS_LOADING_METADATA_REDESIGNED = `${ORIGIN_METADATA_SIDEBAR}${BASE_EVENT_NAME}`; |
There was a problem hiding this comment.
After further consideration I decided to leave ORIGIN_METADATA_SIDEBAR_REDESIGN and apply it properly, so we can track the loading performance. I'm sure @jstoffan knows how.
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
from
79e2a5b
to
36f8857
Compare
In this new placeholder component we will be composing new experience from new components from shared-feature
Also use constant in mock to show they connected
jankowiakdawid
force-pushed
the
add-placehoder-metadatasidebar-redesigned
branch
from
36f8857
to
8e3e443
Compare
tjuanitas
approved these changes
Jul 18, 2024
kajarosz
pushed a commit
to kajarosz/box-ui-elements
that referenced
this pull request
Aug 21, 2024
…#3570) * feat(content-sidebar): Introduce redesigned MetadataSidebar placeholder In this new placeholder component we will be composing new experience from new components from shared-feature * feat(content-sidebar): Use isFeatureEnabled utility * feat(content-sidebar): Remove lint disabling comments * feat(content-sidebar): Rename component to MetadataSidebarRedesign * feat(content-sidebar): Rename constant value to match it's name Also use constant in mock to show they connected * feat(content-sidebar): Rename class name to follow SUIT naming * feat(content-sidebar): Remove unneeded ref and constant * feat(content-sidebar): Remove unneeded constant * feat(content-sidebar): Add performance mark for MetadataSidebarRedesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new placeholder component for work on redesigning Metadata Sidebar.
At current state this placeholder component doesn't offer much functionality nor look.
The idea is to have this component to align and parallel work on upgrading MetadataSidebar to use Blueprint-web components and extends it's functionality with AI.
The component is being lazy loaded to not add to main bundle, and is hidden behind additional feature flag.