Fix: Only focus preview when auto focus is allowed #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the preview is not focusing itself and making the parent page jump. Auto focus helps with keyboard shortcuts. Also fixes references to React 16 in test files. UI Elements aren't compatible with React 15.
|
Verified that @priyajeet has signed the CLA. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the preview is not focusing itself and making the parent page jump. Auto focus helps with keyboard shortcuts. Autofocus is set to true when using content explorer.
Fixes typo in options to prevent preview library attach its own hotkey handlers.
Also fixes references to React 16 in test files. UI Elements aren't compatible with React 15.