New: Thumbnails Sidebar #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now cuts thumbnail images to insert into sidebar. Current approach as to *when* to render thumbnail images is to introduce a `onScrollEnd` callback from the `VirtualScroller` so that when scrolling ends, we look at what list items are rendered and then ask PDFJS to generate the thumbnail image. The `VirtualScroller` `renderItemFn` is invoked by a throttled scroll event handler which is used to create a placeholder thumbnail which includes the page number indicator
Handle the click events on the thumbnail elements in order to navigate to that page of the document
Also fixes an issue where elements that request fullscreen in Safari do not get their width set appropriately if it is a flex item in a flex container
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jeremypress
approved these changes
Feb 19, 2019
|
|
||
| this.maxEntries = maxEntries || 500; | ||
| this.cache = {}; | ||
| this.cacheQueue = []; |
There was a problem hiding this comment.
You could initialize cacheQueue as a class field, above the constructor.
No need to set this.cache since that will happen in the super call
Also, give a default value to maxEntries parameter, then you can remove the ||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now supports the thumbnails sidebar for document types.
Click the toggle button to open and close the sidebar
