Fix: filmstrip on previously played video #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @DanDeMicco has signed the CLA. Thanks for the pull request! |
JustinHoldstock
approved these changes
Feb 22, 2018
tonyjin
reviewed
Feb 22, 2018
| /** | ||
| * Called when user moves mouse over the scrubber | ||
| * | ||
| * @param {functon} cb the callback function to be executed |
There was a problem hiding this comment.
Nitpick - @param {Function} cb - The callback function to be executed
Note capital Function (we typically capitalize Object, Function, and Array and lowercase string, boolean, number in JSDoc) and dash between variable name and description
There was a problem hiding this comment.
Good catch, i didnt even manage to spell function right!
tonyjin
reviewed
Feb 22, 2018
tonyjin
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the filmstrip wasn't appearing on hover of the scrubber for previously played video (when scrubber is blue)