Fix: fullscreen controls not shown in IE11 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DanDeMicco, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
|
CLA signed |
JustinHoldstock
approved these changes
Jan 16, 2018
pramodsum
reviewed
Jan 16, 2018
src/lib/Fullscreen.js
Outdated
| document.addEventListener('fullscreenchange', this.fullscreenchangeHandler); | ||
| // as of now (1/12/18) fullscreenchange is not universally adopted, fscreen will | ||
| // detect and add the appropriate vendor prefixed event | ||
| fscreen.addEventListener('fullscreenchange', this.fullscreenchangeHandler); |
There was a problem hiding this comment.
Can you add a unit test to check that only one handler is added per vendor?
There was a problem hiding this comment.
Added a UT + some refactoring to the PR
priyajeet
reviewed
Jan 16, 2018
| @@ -1,4 +1,6 @@ | |||
| import EventEmitter from 'events'; | |||
| import fscreen from 'fscreen'; | |||
There was a problem hiding this comment.
I would change all functions below to also use it...so that we don't have a mix of native vs lib.
There was a problem hiding this comment.
@priyajeet I will create a ticket to refactor this file
Slight refactor of Fullscreen.js to have separate methods for binding and unbinding events for testing purposes as spies werent working. Also added destroy function as events werent being unbound.
jeremypress
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IE11 was fullscreened it cut off the bottom controls. This was due to a class that gets added when the header is present. The class is supposed to be removed in fullscreen and preview should be shifted up, so the controls won't be cut off.
The issue occured because there was multiple event listeners which got added in the constructor of Fullscreen.js due to the fullscreen API sometimes requiring vendor prefixes Fullscreen API. This caused the toggle function to be called an even number of times, thus removing and re-adding the header class.
Following the suggestion from MDN, I added fscreen to resolve the cross browser differences and only add 1 event listener instead of 4.