Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove unhandled errors from unit tests #498

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Fix: Remove unhandled errors from unit tests #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022f94c
Fix: Remove unhandled errors from unit tests
Nov 21, 2017
5d303b6
Merge branch 'master' into unit-tests
Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/lib/viewers/box3d/image360/__tests__/Image360Renderer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,6 @@ describe('lib/viewers/box3d/image360/Image360Renderer', () => {
});
});

describe('loadPanoramaFile()', () => {
it('should have @jholdstock implement this test after @mbond gets 3D image representations in prod');
});

describe('enableVr()', () => {
beforeEach(() => {
// We don't care about super calls :D
Expand Down
24 changes: 12 additions & 12 deletions src/lib/viewers/doc/__tests__/DocBaseViewer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,12 +749,12 @@ describe('src/lib/viewers/doc/DocBaseViewer', () => {
docBase.isMobile = false;
sandbox.stub(PDFJS, 'getDocument').returns(Promise.resolve({}));

docBase.initViewer('');

expect(stubs.pdfViewerStub).to.be.calledWith({
container: sinon.match.any,
linkService: sinon.match.any,
enhanceTextSelection: true
return docBase.initViewer('').then(() => {
expect(stubs.pdfViewerStub).to.be.calledWith({
container: sinon.match.any,
linkService: sinon.match.any,
enhanceTextSelection: true
});
});
});

Expand All @@ -765,12 +765,12 @@ describe('src/lib/viewers/doc/DocBaseViewer', () => {
docBase.isMobile = true;
sandbox.stub(PDFJS, 'getDocument').returns(Promise.resolve({}));

docBase.initViewer('');

expect(stubs.pdfViewerStub).to.be.calledWith({
container: sinon.match.any,
linkService: sinon.match.any,
enhanceTextSelection: false
return docBase.initViewer('').then(() => {
expect(stubs.pdfViewerStub).to.be.calledWith({
container: sinon.match.any,
linkService: sinon.match.any,
enhanceTextSelection: false
});
});
});

Expand Down
3 changes: 2 additions & 1 deletion src/lib/viewers/media/__tests__/MediaBaseViewer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,9 @@ describe('lib/viewers/media/MediaBaseViewer', () => {
describe('errorHandler', () => {
it('should emit the error and set a display message', () => {
sandbox.stub(media, 'emit');

const err = new Error('blah');
sandbox.mock(window.console).expects('error').withArgs(err);

media.errorHandler(err);

err.displayMessage = 'We\'re sorry, the preview didn\'t load. Please refresh the page.';
Expand Down