Fix: COXP-3500 Reset camera issue in Box3D #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjin
suggested changes
Apr 4, 2017
There was a problem hiding this comment.
When upgrading packages, please don't modify the existing one. Clone the 3D static assets 0.112.0 directory into a new folder with the name of the current package version (0.114.0) and make your updates there.
Also update constant.js MODEL3D_STATIC_ASSETS_VERSION to 0.114.0
This is because we've moved third party assets to a higher level directory - https://cdn01.boxcdn.net/platform/preview/third-party/... if you modify the existing files in model3d/0.112.0, it's highly possible users have that cached and we'd run into unexpected behavior.
added 3 commits
April 4, 2017 16:04
…fix-COXP-3500-camera-reset-issue
…Bond/box-content-preview into 512-fix-COXP-3500-camera-reset-issue
|
Gotcha. Thanks. |
tonyjin
approved these changes
Apr 4, 2017
|
Oh also - @MiiBond please remove JIRA ticket numbers from pull requests since this will be a public repo. |
…fix-COXP-3500-camera-reset-issue
…Bond/box-content-preview into 512-fix-COXP-3500-camera-reset-issue
…fix-COXP-3500-camera-reset-issue
tonyjin
pushed a commit
to tonyjin/box-content-preview
that referenced
this pull request
Nov 29, 2017
https://github.com/box/box-annotations/releases * Chore: Disable dialog actions until annotation is saved on the server (box#48) ([6dbcda2](box/box-annotations@6dbcda2)) * Chore: Remove autobind from base classes (box#44) ([639f8d2](box/box-annotations@639f8d2)) * Chore: Remove autobind from doc classes (box#46) ([d7ded88](box/box-annotations@d7ded88)) * Chore: Remove autobind from Image classes (box#45) ([1dda3a4](box/box-annotations@1dda3a4)) * Chore: Remove NPM install from release/publish scripts (box#50) ([48822c4](box/box-annotations@48822c4)) * Update: Remaining packages (box#49) ([4dab273](box/box-annotations@4dab273)) * Update: Sinon to v4.1.2 & remove autobind-decorator (box#47) ([eea7dcf](box/box-annotations@eea7dcf))
tonyjin
added a commit
that referenced
this pull request
Nov 29, 2017
https://github.com/box/box-annotations/releases * Chore: Disable dialog actions until annotation is saved on the server (#48) ([6dbcda2](box/box-annotations@6dbcda2)) * Chore: Remove autobind from base classes (#44) ([639f8d2](box/box-annotations@639f8d2)) * Chore: Remove autobind from doc classes (#46) ([d7ded88](box/box-annotations@d7ded88)) * Chore: Remove autobind from Image classes (#45) ([1dda3a4](box/box-annotations@1dda3a4)) * Chore: Remove NPM install from release/publish scripts (#50) ([48822c4](box/box-annotations@48822c4)) * Update: Remaining packages (#49) ([4dab273](box/box-annotations@4dab273)) * Update: Sinon to v4.1.2 & remove autobind-decorator (#47) ([eea7dcf](box/box-annotations@eea7dcf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.