New: Added enabledTypes property. Backwards compat for disabledTypes #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
approved these changes
Oct 17, 2017
| }, | ||
| { | ||
| NAME: 'Image', | ||
| CONSTRUCTOR: ImageAnnotator, | ||
| VIEWER: ['Image', 'MultiImage'], | ||
| TYPE: [TYPES.point] | ||
| TYPE: [TYPES.point], | ||
| DEFAULT_ENABLED: [TYPES.point] |
There was a problem hiding this comment.
I agree with using DEFAULT_TYPES
| return !viewerConfig.disabledTypes.includes(type); | ||
| }); | ||
| } | ||
| const enabledTypes = viewerConfig.enabledTypes || [...modifiedAnnotator.DEFAULT_ENABLED]; |
There was a problem hiding this comment.
Why do we need the spread operator and then an array? Isn't modifiedAnnotator.DEFAULT_ENABLED already an array?
There was a problem hiding this comment.
I want to make a copy of the array, not modify the original
added 3 commits
October 17, 2017 15:32
…ew into New-add-enabled-annotation-types
pramodsum
approved these changes
Oct 18, 2017
src/lib/annotations/README.md
Outdated
| @@ -139,15 +139,16 @@ preview.show(..., { | |||
| VIEWER_NAME: { | |||
| annotations: { | |||
| enabled: Boolean, // Enables/disables if set. Respects "showAnnotations" if empty | |||
| disabledTypes: String[] // List of annotation types to disable | |||
| enabledTypes: String[] | null // List of annotation types to enable for this viewer. If empty, will respect default types for that annotator. | |||
| disabledTypes: String[] | null // DEPRECATED. List of annotation types to disable. | |||
There was a problem hiding this comment.
let's not add this line so people won't use disabledTypes from here on out
added 2 commits
October 18, 2017 11:11
…ew into New-add-enabled-annotation-types
pramodsum
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
enabledTypesto the annotation configuration, as well as a default enabled annotation types(DEFAULT_ENABLED), if none provided, toANNOTATORS. This allows us to specify all of the allowed kinds of annotators, and the ones that are enabled by default (if no config provided).IE)