Fix: IE11 SVGs without defined width and height default to 0x0 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #324
In chrome, Images without a defined width and height default to 300x150 (width x height).
(https://css-tricks.com/scale-svg/)
(https://connect.microsoft.com/IE/feedbackdetail/view/925655/svg-image-has-0x0-size-in-ie11)
Proposed workaround (and it is truly not ideal as is with most workarounds):
Load the source as text and attempt to parse it as an SVG. If the parsing succeeds, use the aspect ratio from the viewBox to scale the SVG within the 300x150 boundary. The height is the limiting axis in this case so we can use the aspect ratio to scale the width.
If the parsing fails, assume the image is not an SVG and assign it a size of 300x150 by default.