Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filmstrip interval should be determined from rep metadata field #23

Merged
merged 3 commits into from
Mar 28, 2017
Merged

Filmstrip interval should be determined from rep metadata field #23

merged 3 commits into from
Mar 28, 2017
+45 −14

Commits on Mar 28, 2017

  1. Filmstrip interval should be determined from rep metadata field 

    Before, the filmstrip handler assumed that each frame in the filmstrip
corresponded to a single second of the video. Now, it reads a metadata
field from the API to determine the duration of each frame.
    Bryan Huh committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    bf88a8f View commit details
    Browse the repository at this point in the history

  2. Adding comment

    Bryan Huh committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    c4d1495 View commit details
    Browse the repository at this point in the history

  3. Only load filmstrip if metadata and interval exist 

    They will exist after https://scm.dev.box.net/#/c/373490/ goes live
In general, if they don't exist, you can't assume any particular
interval. It's better to not load the filmstrip at all in these cases.
    Bryan Huh committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    43c4f85 View commit details
    Browse the repository at this point in the history