Chore: Scrubber/Media fixes for mobile #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeremypress
commented
Jun 26, 2017
jeremypress
commented
- Enables scrubbing on mobile
- Prevents tap and hold from bringing up copy/paste menu
- makes track title the file name
|
Tests coming soon. I still see two issues with scrubbing in general.
|
pramodsum
approved these changes
Jun 28, 2017
src/lib/viewers/media/Scrubber.js
Outdated
| @@ -77,6 +86,8 @@ const CLASS_SCRUBBER_HOVER = 'bp-media-scrubber-hover'; | |||
| this.playedEl.removeEventListener('mousedown', this.mouseDownHandler); | |||
| this.convertedEl.removeEventListener('mousedown', this.mouseDownHandler); | |||
| this.handleEl.removeEventListener('mousedown', this.mouseDownHandler); | |||
| this.scrubberContainerEl.removeEventListener('touchstart', this.mouseDownHandler); | |||
There was a problem hiding this comment.
does this also need to be inside an if (this.hasTouch) {} ?
There was a problem hiding this comment.
From MDN:
Calling removeEventListener() with arguments that do not identify any currently registered EventListener on the EventTarget has no effect.
| @@ -1,10 +1,12 @@ | |||
| import autobind from 'autobind-decorator'; | |||
| import EventEmitter from 'events'; | |||
| import scrubberTemplate from './Scrubber.html'; | |||
| import Browser from '../../Browser'; | |||
There was a problem hiding this comment.
is this needed? Didn't see it used anywhere in the code you added
There was a problem hiding this comment.
Browser.hasTouch() on line 61
JustinHoldstock
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.