New: centering image prints #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjin
reviewed
Mar 24, 2017
| @@ -286,6 +286,10 @@ class Image extends Base { | |||
| this.printframe = openContentInsideIframe(this.imageEl.outerHTML); | |||
| this.printframe.contentWindow.focus(); | |||
|
|
|||
| this.printImage = this.printframe.contentDocument.querySelector('img'); | |||
| this.printImage.style.display = 'block'; | |||
| this.printImage.style.margin = '0 auto'; | |||
There was a problem hiding this comment.
An alternative way to do this would be to load in a stylesheet like we do in preparePrint() in Text.js. Generally if possible, move styles to a stylesheet.
There was a problem hiding this comment.
Is it worth loading the style sheet for 2 lines?
There was a problem hiding this comment.
I'm on the fence about it, you can make the judgement call.
Pro in JS:
- Tons of other places already set styles in JS
- Only 2 lines
Pro in CSS:
- Slippery slope to add any styles that we could use CSS for in JS
- In case future styles need to be added for multi image, we'd be adding to CSS not more to JS
There was a problem hiding this comment.
I think I'm going to stick with JS. If multi-image printing is introduced I'll happily refactor.
tonyjin
approved these changes
Mar 24, 2017
This was referenced Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.