fix(annotations): Fix annotation region in mobile #1521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the creation of annotation regions when enableAnnotationsDiscoverability is set to false. When
enableAnnotationsDiscoverability
is true, the classbp-annotations-discoverable
is added. This class setspointer-events: none
on the.textLayer
element (see source) to prevent the text layer from intercepting pointer events intended for the region creator. This PR introducespointer-events: none
to the.textLayer
element when the region creation button is enabled (this causes the classbp-annotations-create--region
to be added), allowing users to comment by region even when discoverability is disabled.Behavior before the update:
region-annotations-before.mp4
Behavior after the update:
region-annotations-safari-mobile.mp4
Behavior in other non mobile browsers:
Firefox:
region-annotations-firefox.mp4
Chrome:
region-annotations-chrome.mp4
Safari:
region-annotations-safari.mp4
Edge:
region-annotations-edge.mp4