fix(polyfill): Remove IE11 polyfills #1515
Conversation
Looking at the PR's for the other shims, they don't seem to specify that they were only for IE11. I see that Number.isNaN, includes, and other functions arent unsupported by older Chrome, Firefox, Safari browsers. Need to check what specific browser versions we support. |
Reflect.construct isn't supported on the older versions of Chrome, Firefox, and Safari as well https://caniuse.com/mdn-javascript_builtins_reflect_construct. Given that, if we move forward with the removal, we should be okay with removing the other polyfills as well. |
|
Investigated the polyfilled functions using Reflect.construct: Array.find: Array.findIndex: Array.includes: String.endsWith: Number.isNaN: PerformanceObserver: These are all very old versions of browsers, I think we are safe to remove the polyfill file. We'll just have to make sure we thoroughly QA test. |
|
I agree, we can likely safely remove the polyfill. |
| @@ -50,6 +50,10 @@ describe('lib/Preview', () => { | |||
| preview.logger = new Logger(); | |||
| stubs = {}; | |||
| stubs.api = new Api(); | |||
| window.PerformanceObserver = jest.fn(() => ({ | |||
There was a problem hiding this comment.
Mock needed, similar to PreviewPerf-test.js
IE11 is no longer supported. This removes some polyfills needed for IE11 as those polyfills can cause other issues as we move forward.