Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pdf): override css missing asset #1505

Merged
merged 4 commits into from
Sep 1, 2023
Merged

fix(pdf): override css missing asset #1505

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d431fc9
fix(pdf): override css missing assest
bfoxx1906 Aug 31, 2023
0e8924b
fix(pdf): override css missing assest
bfoxx1906 Sep 1, 2023
da31741
fix(pdf): override css missing assest
bfoxx1906 Sep 1, 2023
3e6a854
fix(preview): chagning version number back
bfoxx1906 Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib/viewers/doc/_docBase.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,12 @@ $thumbnail-sidebar-width: 191px; // Extra pixel to account for sidebar border
background: none;
}

&.loadingIcon::after {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should prevent the browser from calling out to the loading icon file, but I don't think it will fix our custom loading experience. We'll need a follow-up change and release for that.

top: $pdfjs-page-padding;
bottom: $pdfjs-page-padding;
background: none;
}

// Fixes annotation icon broken src
.textAnnotation > img {
opacity: 0;
Expand Down