Fix: Seek time doesn't match filmstrip timecode #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjin
reviewed
May 22, 2017
src/lib/viewers/media/Scrubber.js
Outdated
| return Math.max(Math.min(relPos, MAX_VALUE), MIN_VALUE); | ||
| } | ||
|
|
||
| /** | ||
| * Calculates the position of the scrubber handle based on mouse action | ||
| * | ||
| * @private | ||
| * @param {Event} event - the instance of the class |
There was a problem hiding this comment.
Can you fix this JSDoc while you're in here? Instance of the class doesn't seem right
tonyjin
approved these changes
May 22, 2017
JustinHoldstock
approved these changes
May 22, 2017
Previously, hovering over a time in the scrubber to seek to that point would display a timecode that doesn't match the actual time that the seek would take you to. This was more apparent in longer videos. For example, hovering over 10:00 in a 1hr video, and clicking at that point would actually take you to 9:30. This was due to two different ways the timecodes (the filmstrip timecode versus the seeked timecode) were calculated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, hovering over a time in the scrubber to seek to that point
would display a timecode that doesn't match the actual time that the
seek would take you to. This was more apparent in longer videos. For
example, hovering over 10:00 in a 1hr video, and clicking at that point
would actually take you to 9:30. This was due to two different ways the
timecodes (the filmstrip timecode versus the seeked timecode) were
calculated.