feat(controls): Add react version of mp3 controls behind option #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
force-pushed
the
react-ui-mp3
branch
from
4e9fd42
to
a10ca1e
Compare
jstoffan
force-pushed
the
react-ui-mp3
branch
2 times, most recently
from
21e0161
to
d583bde
Compare
jstoffan
force-pushed
the
react-ui-mp3
branch
from
d583bde
to
68e782c
Compare
jstoffan
force-pushed
the
react-ui-mp3
branch
from
68e782c
to
7fbc221
Compare
jstoffan
changed the title
jstoffan
commented
Jan 12, 2021
| this.cache.set(MEDIA_SPEED_CACHE_KEY, '1.0'); | ||
| } | ||
|
|
||
| this.controls = new MediaControlsRoot({ containerEl: this.containerEl }); |
There was a problem hiding this comment.
This will likely end up renamed/moved to the MP3Viewer once the video controls are introduced, since the latter has auto-hide/show behavior similar to the document viewers.
mxiao6
approved these changes
Jan 12, 2021
| @@ -403,6 +409,10 @@ class MediaBaseViewer extends BaseViewer { | |||
| this.debouncedEmit('volume', volume); | |||
| this.mediaEl.volume = volume; | |||
| } | |||
|
|
|||
| if (this.controls) { | |||
There was a problem hiding this comment.
Is this guard clause necessary? There's another one inside renderUI.
There was a problem hiding this comment.
It's not strictly necessary since renderUI is a noop otherwise. I can remove it.
There was a problem hiding this comment.
It's ok. I just find it's not consistent with line 553: https://github.com/box/box-content-preview/pull/1302/files#diff-242d253d5790db64a7f3a5f5a65fe30ee9045543c45bd03b46c77271058002d0R553. It doesn't have the guard clause.
ConradJChan
approved these changes
Jan 13, 2021
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo