Update: Adding more languages for subtitles #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds more subtitle languages. Before we were limiting ourselves to the official list of Box supported languages, but really that should only apply to translations of the languages (i.e. the set of properties files we have). If a video has a subtitle in it with a particular language that we don't officially support, there's no reason to give a degraded experience - all we need to do is maintain a language-code mapping for that language, and we don't need to even translate anything into that language (just translate the language name into our officially supported languages).
|
There's an even longer list of languages I had created here: bhh1988@b9152e5 But I threw out most of the obscure ones |
|
This adds 131 bytes to preview.js |
tonyjin
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds more subtitle languages. Before we were limiting
ourselves to the official list of Box supported languages, but really
that should only apply to translations of the languages (i.e. the set of
properties files we have). If a video has a subtitle in it with a
particular language that we don't officially support, there's no reason
to give a degraded experience - all we need to do is maintain a
language-code mapping for that language, and we don't need to even
translate anything into that language (just translate the language name
into our officially supported languages).