fix(archive): Reset vertical scroll when navigating folders #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
jstoffan
previously approved these changes
Feb 5, 2020
| table.scrollTo(0, 50); | ||
|
|
||
| const tableTop = table.getBoundingClientRect().top; | ||
| cy.get('.ReactVirtualized__Table__row').then($rows => { |
There was a problem hiding this comment.
Any way we can avoid using CSS classes here?
There was a problem hiding this comment.
I think so, yeah, since it's based on user-visible information. We do it in other tests, too.
test/support/constants.js
Outdated
| @@ -2,6 +2,7 @@ Cypress.env({ | |||
| // NOTE: The token used is a readonly token accessing public data in a demo enterprise. | |||
| ACCESS_TOKEN: 'S8wjvjOL9GEK5VtXsQNVMOwSrx1g55oC', | |||
| FILE_ID_ARCHIVE: '589625563707', | |||
| FILE_ID_ARCHIVE_LONG: '611800378713', | |||
There was a problem hiding this comment.
It looks like we have FILE_ID_DOC_LARGE. Can we rename to FILE_ID_ARCHIVE_LARGE, as well?
jstoffan
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.