Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(archive): Add e2e test #1140

Merged
merged 1 commit into from
Jan 17, 2020
Merged

test(archive): Add e2e test #1140

merged 1 commit into from
Jan 17, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jan 4, 2020

The test is failing because conversion feature flip is not on for our e2e test account. The account is live, so we have to wait until the next week. The test works on my dev vm.

@mxiao6 mxiao6 requested a review from a team as a code owner January 4, 2020 00:35
@boxcla
Copy link

boxcla commented Jan 4, 2020

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

cy.get('button').click();
});

cy.get('.bp-SearchBar input').type('level');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using data-testid for selectors rather than CSS classes.

jstoffan
jstoffan previously approved these changes Jan 17, 2020
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really a feat, as it doesn't introduce user-facing behavior. I would rename the commit type to test.

@mxiao6 mxiao6 changed the title feat(archive): Add e2e test test(archive): Add e2e test Jan 17, 2020
@mergify mergify bot merged commit 6fd3ce3 into box:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants