build(config): Switch to @box/frontend package for configs #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jstoffan
commented
Jul 18, 2019
| }, | ||
| rules: { | ||
| 'class-methods-use-this': 0, // fixme | ||
| 'import/no-cycle': 0, // fixme |
There was a problem hiding this comment.
I have a commit to resolve this, but I'm going to PR it separately because it requires more significant code modifications.
jstoffan
force-pushed
the
refactor-frontend
branch
from
f198b1b
to
ece9bcf
Compare
mickr
previously approved these changes
Jul 18, 2019
jstoffan
force-pushed
the
refactor-frontend
branch
from
ee1a571
to
72313d3
Compare
mickr
approved these changes
Jul 18, 2019
mickr
pushed a commit
to mickr/box-content-preview
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.