Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error-messages): Update error messages in preview #1519

Merged
merged 3 commits into from
May 24, 2024

Conversation

marcoartaviaq
Copy link
Contributor

Update preview error messages to let users know they can download/open the file to view it.

@marcoartaviaq marcoartaviaq requested a review from a team as a code owner May 21, 2024 23:28
src/i18n/en-US.properties Show resolved Hide resolved
jstoffan
jstoffan previously approved these changes May 24, 2024
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for refining the messages!

src/i18n/en-US.properties Outdated Show resolved Hide resolved
jstoffan
jstoffan previously approved these changes May 24, 2024
Update failing e2e test

Co-Authored-By: Jared Stoffan <jstoffan@users.noreply.github.com>
@mergify mergify bot merged commit 89fa483 into box:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants