Skip to content

Commit

Permalink
feat(error-messages): Update error messages in preview (#1519)
Browse files Browse the repository at this point in the history
* feat(error-messages): Update error messages in preview

* fix(error-messages): Update error messages

* fix(error-messages): Adress feedback

Update failing e2e test

Co-Authored-By: Jared Stoffan <jstoffan@users.noreply.github.com>

---------

Co-authored-by: Jared Stoffan <jstoffan@users.noreply.github.com>
  • Loading branch information
marcoartaviaq and jstoffan authored May 24, 2024
1 parent 5f1da66 commit 89fa483
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 29 deletions.
50 changes: 25 additions & 25 deletions src/i18n/en-US.properties
Original file line number Diff line number Diff line change
Expand Up @@ -67,35 +67,35 @@ file_preview_label=File preview

# Error messages
# Default preview error message
error_generic=We’re sorry, the preview didn’t load.
error_generic=This preview didn’t load. Please try to open or download the file to view.
# Default preview error message
error_unsupported=We’re sorry, we can’t preview this file type in your web browser. To view this content please download and open it on your device.
error_unsupported=This preview didn’t load because the file type is unsupported. Please try to open or download the file to view.
# Account doesn’t have a sufficient tariff to preview the requested file type
error_account=We’re sorry, your account is unable to preview this file type.
error_account=This preview didn’t load because your account is unable to preview this file type. Please try to open or download the file to view.
# No permissions preview error message
error_permissions=We’re sorry, you don’t have permission to preview this file.
# Preview refresh error message suggesting refreshing the page as a possible fix
error_refresh=We’re sorry, the preview didn’t load. Please refresh the page.
error_permissions=This preview didn’t load because you don’t have permission. Please ask the file owner to update permissions.
# Preview refresh error message suggesting opening or downloading as a possible fix
error_refresh=This preview didn’t load. Please try to open or download the file to view.
# Preview rate limit error suggesting waiting a few minutes to avoid rate limit
error_rate_limit=We’re sorry, the preview didn’t load because your request was rate limited. Please wait a few minutes and try again.
# Preview re-upload error message suggesting re-uploading the file or contacting support as a possible fix
error_reupload=We’re sorry, the preview didn’t load. Please re-upload the file or contact Box support.
error_rate_limit=This preview didn’t load because your request was rate limited. Please try to open or download the file to view.
# Preview re-upload error message suggesting opening or downloading as a possible fix
error_reupload=This preview didn’t load. Please try to open or download the file to view.
# Preview error message shown when the user’s browser doesn’t support previews of this file type
error_browser_unsupported=We’re sorry, your browser doesn’t support preview for {1}.
error_browser_unsupported=Your browser doesn’t support preview for {1}. Please try to open or download the file to view.
# Preview error message shown when document loading fails (most likely due to password or watermark)
error_document=We’re sorry, the preview didn’t load. This document may be protected.
error_document=This preview didn’t load because the document may be protected. Please try to open or download the file to view.
# Preview error message shown when the document is password protected
error_password_protected=We’re sorry the preview didn’t load. This document is protected.
error_password_protected=This preview didn’t load because the document is protected. Please try to open or download the file to view.
# Preview error message shown when conversion was unable to process the file at the given time.
error_try_again_later=We’re sorry the preview didn’t load. Please try again later.
# Preview error message shown when conversion failed due to file contents
error_bad_file=We’re sorry the preview didn’t load. This file could not be converted.
error_try_again_later=This preview didn’t load. Please refresh the page or download file to view.
# Preview error message shown when conversion failed due to file contents, suggesting opening or downloading as a possible fix
error_bad_file=This preview didn’t load. Please try to open or download the file to view.
# Preview error message shown when the file cannot be downloaded
error_not_downloadable=Oops! It looks like something is wrong with this file. We apologize for the inconvenience and recommend that you upload a new version of this file or roll back to a previous version. Please contact us for more details.
error_not_downloadable=Something seems to be wrong with this file. Please refresh the page, and if the issue continues, try to upload a new version.
# Preview error message shown when flash is not enabled on their browser
error_flash_not_enabled=We’re sorry, the preview didn’t load because Flash is not enabled on your browser. If possible, please enable Flash and refresh the page.
error_flash_not_enabled=This preview didn’t load because Flash is not enabled on your browser. Please try to enable Flash or download the file to view.
# Preview error message shown when loading what would be an Office Excel Online file extension in Internet Explorer
error_internet_explorer_office_online=Microsoft 365 apps and services no longer support Internet Explorer 11, therefore, Box users may have a degraded experience.
error_internet_explorer_office_online=This version of Internet Explorer is out of date and the experience may be degraded. Please try switching to a different browser for a better experience.
# Preview error message shown when the preview fails because the file is too large for its extension type
error_large_file=File exceeds supported size for preview. Open or download the file to view.
# Preview error message shown when the preview fails because the file does not contain data
Expand Down Expand Up @@ -246,13 +246,13 @@ annotation_draw_save=Save drawing
# Accessibilty text for button that soft deletes drawing
annotation_draw_delete=Delete drawing
# Text for when annotations fail to load
annotations_load_error=We’re sorry, annotations failed to load for this file.
annotations_load_error=Annotations could not be loaded for this file. Please refresh the page to try again.
# Text for when the annotation can’t be created
annotations_create_error=We’re sorry, the annotation could not be created.
annotations_create_error=This annotation could not be created. Please try again.
# Text for when the annotation can’t be deleted
annotations_delete_error=We’re sorry, the annotation could not be deleted.
annotations_delete_error=This annotation could not be deleted. Please try again.
# Text for when the authorization token is invalid
annotations_authorization_error=Your session has expired. Please refresh the page.
annotations_authorization_error=Annotations could not be loaded for this file. You may not have permission to take this action.
# Text for Tooltip content showing new users about annotations experience
annotations_tooltip_body=Make notes and comments to highlight key information when previewing content.
# Text for Tooltip title showing new users about annotations experience
Expand All @@ -268,11 +268,11 @@ notification_annotation_point_mode=Click anywhere to add a comment to the docume
# Notification message shown when user enters drawing annotation mode
notification_annotation_draw_mode=Press down and drag the pointer to draw on the document
# Notification message shown when the user has a degraded preview experience due to blocked download hosts
notification_degraded_preview=It looks like your connection to {1} is being blocked. We think we can make file previews faster for you. To do that, please ask your network admin to configure firewall settings so that {1} is reachable.
notification_degraded_preview=Your connection to [1] is being blocked. Please reach out to your network admin to adjust firewall settings.
# Notification message shown when a file cannot be downloaded
notification_cannot_download=Sorry! You can’t download this file.
notification_cannot_download=This file could not be downloaded.
# Notification message shown when a file cannot be downloaded due to an access policy
notification_cannot_download_due_to_policy=Downloading of this content has been disabled based on an access policy.
notification_cannot_download_due_to_policy=The file could not be downloaded due to a security policy.

# Link Text
link_contact_us=Contact Us
Expand Down
8 changes: 6 additions & 2 deletions src/lib/__tests__/PreviewError-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,16 @@ describe('lib/PreviewError', () => {

test('should default display message to generic error message if not provided', () => {
const previewError = new PreviewError('some_code');
expect(previewError.displayMessage).toBe('We’re sorry, the preview didn’t load.');
expect(previewError.displayMessage).toBe(
'This preview didn’t load. Please try to open or download the file to view.',
);
});

test('should default message to display message if message is not provided', () => {
const previewError = new PreviewError('some_code');
expect(previewError.message).toBe('We’re sorry, the preview didn’t load.');
expect(previewError.message).toBe(
'This preview didn’t load. Please try to open or download the file to view.',
);
});
});
});
4 changes: 2 additions & 2 deletions test/integration/sanity/Download.e2e.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('Download disabled while preview is already open', () => {

cy.getByTestId('preview-error-download-btn').should('be.visible');
cy.getByTestId('preview-error-download-btn').click();
cy.contains('Sorry! You can’t download this file.');
cy.contains('This file could not be downloaded.');
});

it('should give shield error when trying to download and access policy prevents download', () => {
Expand All @@ -25,6 +25,6 @@ describe('Download disabled while preview is already open', () => {

cy.getByTestId('preview-error-download-btn').should('be.visible');
cy.getByTestId('preview-error-download-btn').click();
cy.contains('Downloading of this content has been disabled based on an access policy.');
cy.contains('The file could not be downloaded due to a security policy.');
});
});

0 comments on commit 89fa483

Please sign in to comment.