Fix: Pending highlight is not cleared on powerpoint page scroll #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Mar 1, 2018
| @@ -396,6 +397,7 @@ class DocAnnotator extends Annotator { | |||
| // Highlight listeners on desktop & mobile | |||
| if (this.plainHighlightEnabled || this.commentHighlightEnabled) { | |||
| this.annotatedElement.addEventListener('mouseup', this.highlightMouseupHandler); | |||
| this.annotatedElement.addEventListener('wheel', this.resetHighlightSelection); | |||
There was a problem hiding this comment.
Does wheel also fire if you are scrolling through overflowed content in a dialog? That might clear things?
There was a problem hiding this comment.
i'll add a check to only reset the highlight if the mouse is not over an annotation dialog
jeremypress
reviewed
Mar 2, 2018
jeremypress
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.