Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime component issue solution #881

Closed
wants to merge 1 commit into from

Conversation

aradoje
Copy link
Contributor

@aradoje aradoje commented Feb 14, 2023

Closes #655.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.†

†: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

3 similar comments
@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.†

†: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.†

†: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.†

†: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.*

*: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

3 similar comments
@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.*

*: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.*

*: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

@theofidry
Copy link
Member

Thank you for the PR @aradoje.

I'm unfortunately not going to merge this immediately for a few reasons:

  • I would like to add an E2E test within Box to ensure it works fine with Symfony6, with or without the suggested solution (see doc: Add a Symfony6 example #886)
  • I think the current suggested solution is sub-par: when you end up doing is circumventing the Symfony runtime component: so it will work within the PHAR, but the regular console script no longer really use the runtime component. IMO a cleaner solution would be to remove the runtime component altogether.*

*: I opened symfony/symfony#49443 because I do think the runtime component should just work with PHARs out of the box, rather than requiring more fiddling.

This was referenced Feb 19, 2023
@theofidry
Copy link
Member

Merged via #886

@theofidry theofidry closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working Symfony 6 example?
2 participants