Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update php-scoper + bump min PHP version to 7.3 #499

Merged
merged 5 commits into from
Nov 30, 2020
Merged

update php-scoper + bump min PHP version to 7.3 #499

merged 5 commits into from
Nov 30, 2020

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Nov 11, 2020 •
edited
Loading

This will fix also the issue with scoping php-parser in #489

@smoench smoench mentioned this pull request Nov 11, 2020
Closed
@smoench
Copy link
Contributor Author

smoench commented Nov 11, 2020

Travis failure is related to nikic/PHP-Parser#701

@villfa
Copy link
Contributor

villfa commented Nov 11, 2020

FYI there is also some tests failing because of a breaking change in Composer 2.0.5 (platform_check.php is not generated by default anymore).

@theofidry
Copy link
Member

Is it something we want now or should I go ahead with another release first?

@smoench
Copy link
Contributor Author

smoench commented Nov 17, 2020

No, not yet. Go ahead with another release :-)

@smoench smoench changed the title update php-scoper to latest version 0.13.9 WIP: update php-scoper Nov 17, 2020
@smoench
Copy link
Contributor Author

smoench commented Nov 17, 2020

There is an issue with scoping php-parser with the current php-scoper version. I could fix it with humbug/php-scoper#437. But I had bump min PHP version to 7.3 as it has been done in php-scoper too.

@smoench smoench mentioned this pull request Nov 17, 2020
Merged
@smoench
Copy link
Contributor Author

smoench commented Nov 18, 2020

@theofidry Bump min PHP version to 7.3 causes tests failures. Can we revert php-scoper or have a branch with PHP 7.2 support?

@theofidry
Copy link
Member

@smoench sorry I'm not sure to understand, why do we need 7.2 support?

@smoench
Copy link
Contributor Author

smoench commented Nov 18, 2020

Composer won't let us install the latest php-scoper version as in box's composer.json the platform config for PHP is fixed to 7.2.9.

@theofidry
Copy link
Member

But if we drop 7.2 (which was the plan) then this value should be bumped right?

@smoench
Copy link
Contributor Author

smoench commented Nov 18, 2020

Docker e2e tests had to be updated. Works now.

@smoench smoench changed the title WIP: update php-scoper update php-scoper + bump min PHP version to 7.3 Nov 18, 2020
@smoench
Copy link
Contributor Author

smoench commented Nov 18, 2020

Waiting for humbug/php-scoper#437 to be merged and a new php-scoper release :)

@theofidry
Copy link
Member

https://github.com/humbug/php-scoper/releases/tag/0.13.10 released

@smoench
Copy link
Contributor Author

smoench commented Nov 30, 2020

Thank you @theofidry. I've updated the composer.json :-)

theofidry
theofidry approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks!

composer.json Show resolved Hide resolved
@theofidry theofidry merged commit 458a695 into box-project:master Nov 30, 2020
@smoench smoench deleted the update-php-scoper branch November 30, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theofidry theofidry theofidry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoench @villfa @theofidry