Add an extract command #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
feature/extract
branch
from
848631b
to
af4a939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383
@dshafik sorry for the ping: Marco told me you would be the person to talk to :P
I'm having an issue with this feature: I'm trying to add a command to extract a PHAR and take care of the annoying little things such as the
phar.readonlyconfiguration, the file descriptors limit, appending the.pharextension...I'm however having an issue as I cannot (at all) uncompress the PHAR before extracting it: whatever I call, the extracted content will be the compressed content of the PHAR hence unreadable. Do you have any idea how I could solve this?