Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the autoloading of the excluded files #1323

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Mar 8, 2024

This fixes the integration of
humbug/php-scoper#864 within Box which was done in #1142.

The issue was that the relative file paths was passed instead of hashes. Note that we create the file hasher in a different way than in PHP-Scoper, since PHP-Scoper has to deal with the vendor directory from the source and the scoped one, and deals with absolute paths. In Box however, this is not the case, we directly get relative file paths (relative to the working directory)

@theofidry theofidry marked this pull request as ready for review March 8, 2024 14:31
@theofidry
Copy link
Member Author

Waiting for feedback on phpstan/phpstan-src#2905

@theofidry theofidry enabled auto-merge (squash) April 7, 2024 19:39
@theofidry
Copy link
Member Author

From my testing this looks to be fixing the issues. There is more issues related to the polyfill but that's a separate PHP-Scoper issue.

@theofidry theofidry merged commit d83ec37 into box-project:main Apr 7, 2024
161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant