refactor: Simplify the sorting in the requirement builder (#1327)

- Move sorting the extensions into a dedicated explicit method for
  better re-usability.
- Provide directly the whole sorted data set rather than a partially
  sorted one.

src/RequirementChecker/RequirementsBuilder.php

@@ -16,6 +16,7 @@
 
 use KevinGH\Box\Composer\Package\Extension;
 use function array_diff_key;
+use function array_map;
 use function array_unique;
 use function natsort;
 use function strnatcmp;
@@ -53,9 +54,7 @@ public function build(): Requirements
         $requirements = $this->predefinedRequirements;
 
         foreach ($this->getSortedRequiredExtensions() as $extensionName => $sources) {
-            $sortedDistinctSources = self::createSortedDistinctList($sources);
-
-            foreach ($sortedDistinctSources as $source) {
+            foreach ($sources as $source) {
                 $requirements[] = Requirement::forRequiredExtension(
                     $extensionName,
                     $source,
@@ -64,9 +63,7 @@ public function build(): Requirements
         }
 
         foreach ($this->getSortedConflictedExtensions() as $extensionName => $sources) {
-            $sortedDistinctSources = self::createSortedDistinctList($sources);
-
-            foreach ($sortedDistinctSources as $source) {
+            foreach ($sources as $source) {
                 $requirements[] = Requirement::forConflictingExtension(
                     $extensionName,
                     $source,
@@ -82,23 +79,36 @@ public function build(): Requirements
      */
     private function getSortedRequiredExtensions(): array
     {
-        $extensions = array_diff_key(
-            $this->requiredExtensions,
-            $this->providedExtensions,
+        return array_map(
+            self::createSortedDistinctList(...),
+            self::sortByExtensionName(
+                array_diff_key(
+                    $this->requiredExtensions,
+                    $this->providedExtensions,
+                ),
+            ),
         );
-
-        uksort($extensions, strnatcmp(...));
-
-        return $extensions;
     }
 
     /**
      * @return array<string, list<string>>
      */
     private function getSortedConflictedExtensions(): array
     {
-        $extensions = $this->conflictingExtensions;
+        return array_map(
+            self::createSortedDistinctList(...),
+            self::sortByExtensionName($this->conflictingExtensions),
+        );
+    }
 
+    /**
+     * @template T
+     *
+     * @param  array<string, T> $extensions
+     * @return array<string, T>
+     */
+    private static function sortByExtensionName(array $extensions): array
+    {
         uksort($extensions, strnatcmp(...));
 
         return $extensions;