Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updog: auto-validate lists of updates #480

Closed
tjkirch opened this issue Oct 31, 2019 · 2 comments
Closed

updog: auto-validate lists of updates #480

tjkirch opened this issue Oct 31, 2019 · 2 comments
Labels
area/core Issues core to the OS (variant independent) status/needs-triage Pending triage or re-evaluation type/bug Something isn't working
Milestone
techdebt

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Oct 31, 2019 •
edited
Loading

Instead of needing to remember to call validate, what if we reify a "list of updates" type and error immediately if adding an update with an incompatible wave?

Originally posted by @tjkirch in #265 (comment)
@sam-aws sam-aws mentioned this issue Nov 1, 2019
Merged
@tjkirch
Copy link
Contributor Author

tjkirch commented Nov 1, 2019

Another idea is to create an UpdateIdentifier so we don't have to remember to check all the right fields in an Update in comparisons:

#265 (comment)

@sam-aws sam-aws mentioned this issue Dec 4, 2019
Closed
@gregdek gregdek added status/notstarted type/bug Something isn't working labels Apr 2, 2021
@gregdek gregdek added this to the techdebt milestone Apr 2, 2021
@samuelkarp samuelkarp added the area/core Issues core to the OS (variant independent) label Aug 3, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p2 labels Dec 1, 2022
@jpmcb
Copy link
Contributor

jpmcb commented Dec 12, 2022

Closing. WaveArgs.validate no longer exists in Updog source code.

@jpmcb jpmcb closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core Issues core to the OS (variant independent) status/needs-triage Pending triage or re-evaluation type/bug Something isn't working
Projects
None yet
Milestone
techdebt
Development

No branches or pull requests
5 participants
@tjkirch @gregdek @samuelkarp @stmcginnis @jpmcb