Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-ctr image pull: differentiate transient and permanent errors and handle them differently #443

Open
etungsten opened this issue Oct 21, 2019 · 2 comments
Assignees
Labels
area/core Issues core to the OS (variant independent) type/enhancement New feature or request

Comments

@etungsten
Copy link
Contributor

Either way, I think to make this reliable we'll also want to further designate errors to be handled to determine transient failures (where possible) from permanent failures (eg: user specified a bad image). This can be a fast follow item IMO. I think this already gets us to a better standing in terms of transient errors.

Originally posted by @jahkeup #433 (review)

@etungsten
Copy link
Contributor Author

etungsten commented Oct 21, 2019

Hopefully somewhere down the line we can leverage what's being discussed here https://blog.golang.org/go1.13-errors

@jahkeup
Copy link
Member

jahkeup commented Oct 22, 2019

We do have some of these provided by the use of the github.com/pkg/errors package in the downstream project - so we may be able to dig in. However, this may not be help if there's not predefined errors or distinguishable errors used - which on cursory glance appears to be the case at the API surface area; it is possible the api surface area is bubbling up well defined errors we can handle though.

@iliana iliana changed the title host-ctr image pull: differentiate transient and permenant errors and handle them differently host-ctr image pull: differentiate transient and permanent errors and handle them differently Feb 26, 2020
@jhaynes jhaynes added this to the GA milestone Apr 9, 2020
@tjkirch tjkirch removed this from the GA milestone Aug 18, 2020
@gregdek gregdek added this to the backlog milestone Apr 1, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation area/core Issues core to the OS (variant independent) and removed priority/p2 status/needs-triage Pending triage or re-evaluation labels Dec 1, 2022
@stmcginnis stmcginnis removed this from the backlog milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues core to the OS (variant independent) type/enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

6 participants