Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken build for midpoint_ellipse_rasterizer::draw_curve #705

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix: broken build for midpoint_ellipse_rasterizer::draw_curve #705

merged 2 commits into from
Jul 4, 2022

Conversation

marco-langer
Copy link
Contributor

@marco-langer marco-langer commented Jul 2, 2022 •
edited by mloskot
Loading

Description

This PR fixes a bug in midpoint_ellipse_rasterizer::draw_curve(), which I have introduced in my other PR while working on the apply_rasterizer function. I have also added missing test cases to cover these invocations.

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@codecov
Copy link

codecov bot commented Jul 2, 2022 •
edited
Loading

Codecov Report

Merging #705 (ce61114) into develop (233dc53) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #705      +/-   ##
===========================================
+ Coverage    80.97%   81.10%   +0.13%     
===========================================
  Files          116      117       +1     
  Lines         5130     5171      +41     
===========================================
+ Hits          4154     4194      +40     
- Misses         976      977       +1

@mloskot mloskot added this to the Boost 1.80 milestone Jul 2, 2022
@mloskot mloskot added the ext/rasterization boost/gil/extension/rasterization label Jul 2, 2022
@mloskot mloskot merged commit 573ba13 into boostorg:develop Jul 4, 2022
mloskot added a commit that referenced this pull request Jul 4, 2022
@mloskot
Merge branch 'develop'
4306a66 
* develop:
  fix: broken build for midpoint_ellipse_rasterizer::draw_curve (#705)
  docs: fixed gradient tutorial (#703)
  fix: Unused variable warning (#704)
@mloskot mloskot mentioned this pull request Jul 5, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

Assignees
No one assigned
Labels
ext/rasterization boost/gil/extension/rasterization
Projects
None yet
Milestone
Boost 1.80
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-langer @mloskot