-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers #685
refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers #685
Conversation
93ff3f8
to
65408ac
Compare
Codecov Report
@@ Coverage Diff @@
## develop #685 +/- ##
========================================
Coverage 80.32% 80.32%
========================================
Files 117 117
Lines 5032 5032
========================================
Hits 4042 4042
Misses 990 990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
I don't have much of a clue about macOS in general, but FWIW GitHub Actions is now also offering macOS 12 runners: https://github.blog/changelog/2022-06-13-github-actions-macos-12-for-github-hosted-runners-is-now-generally-available/ Maybe that can be helpful here to extend tests to newer macOS versions. |
1bfaddb
to
42b408c
Compare
This is to hit more lines and make codecov happier, than during recent build of PR #685
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CI's are now green. Thanks again!
* develop: docs!: Announce plan to require C++17 after Boost 1.80 (#694) feat: Added apply_rasterizer() free function (#695) refactor: Ellipse rasterizer according to the comment at (#692) refactor: Deprecate apply_operation in favor of variant2::visit for any_image (#656) refactor: Replace deprecated libtiff v4.3 typedefs with C99 fixed-size integers (#685) fix: Automatic detection of <filesystem> header (#684) test: Add tiled TIFF test case to simple_all_formats test: Add tests for RGB to HSL (#691) refactor: Move RGB to HSL tests to color_convert_rgb.cpp refactor: Make with_tolerance reusable across other tests chore: Correct include guard fix: Add missing #include <array> fix: Wrong RGB -> HSL convertion (#505)
Description
This PR replaces libtiff's fixed-size typedef
uint32
with C99's fixed-size typedefstd::uint32_t
.Rational: libtiff's typedefs are deprecated since v4.3.0 and we already see this deprecation warning in our CI for builds with clang on macos-10.15.
C99's fixed-size typedefs and libtiffs typedefs are almost interchangeable, with the notable exception for 64 bit macOS and a breaking change between long and long long according to this and this discussion. Currently I don't think this will affect Gil as we only used
uint32
from libtiffs typedefs, but nevertheless it might be a good idea to check the impact of this PR on macOS builds before merging it into develop.